Skip to content

Conversation

@Urgau
Copy link
Member

@Urgau Urgau commented Aug 19, 2025

This PR does two things:

  1. it adds a new endpoint /gh-changes-since/{owner}/{repo}/{pr}/{oldbasehead} which either redirect to GitHub's compare page when the base commit is the same or redirect to our range-diff when the base commit changed.
  2. it adds a new handler ([review-changes-since]) which automatically adds a link this newly endpoint on every "review" (see above example)

The goal is to make it easier to review the changes that happened since the review.

Asked by Ralf in #t-compiler > Experimental range-diff for force-push @ 💬

image

@Urgau Urgau requested a review from Kobzol August 19, 2025 18:35
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I start worrying about feature creep a bit, but this genuinely seems useful.. let's try it!

Btw, GitHub might seriously consider paying you for doing R&D 😂

@Urgau Urgau force-pushed the gh-changes-since branch from 3c8a707 to b87d60d Compare August 19, 2025 19:40
@Urgau
Copy link
Member Author

Urgau commented Aug 19, 2025

I start worrying about feature creep a bit, but this genuinely seems useful.. let's try it!

Yeah, we've recently added a bunch of features, fortunately they are all pretty straightforward and IMO simple to maintain. I wouldn't want to implement more complex features and hopefully GitHub will at some point implement them natively.

Btw, GitHub might seriously consider paying you for doing R&D 😂

I wish. I should send them a receipt 😆.

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a doc comment on the review_changes_since handler.

@Urgau Urgau force-pushed the gh-changes-since branch from b87d60d to c9dd46e Compare August 19, 2025 19:56
@Urgau Urgau added this pull request to the merge queue Aug 19, 2025
Merged via the queue into rust-lang:master with commit 5370418 Aug 19, 2025
3 checks passed
@Urgau Urgau deleted the gh-changes-since branch August 19, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants